New MSP command request

This forum is dedicated to software development related to MultiWii.
It is not the right place to submit a setup problem.
Software download
Post Reply
User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

New MSP command request

Post by ezio »

Could you add new MSP command which returns ie a string with name of the firmware ("cleanflight") and the integer with the version?
It will help me and others to adjust features set in the gui.
The same should be done in BaseFlight, MultiWii etc

The problem:
Right now the AUX settings are not supported in EZ-GUI. Using it can cause problems. I want to block the AUX completely for CleanFlight but I don't have a possibly to detect it.

I'm aware of existence MSP_IDENT.
But none uses it. Msp_version hasn't been changed at all, even when old commands were changed and new added.
Also there is no field for firmware version detection ie Baseflight, cleanflight etc.

Adding this field to the MSP_IDENT will add more chaos and it will be not backwards compatible.

Thanks
Bart

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: New MSP command request

Post by Alexinparis »

Hi,

MSP version can already get from another MSP, no plan to duplicate any info

There is currently a field not used in MSP: BOARD_NAME: 16 char long
A new MSP with just this would be enough ?

timecop
Posts: 1880
Joined: Fri Sep 02, 2011 4:48 pm

Re: New MSP command request

Post by timecop »

baseflight already has a version string and extended MSP stuff. I'm all for blocking javaflight tho.

User avatar
treym
Posts: 258
Joined: Sat Jul 21, 2012 12:28 am

Re: New MSP command request

Post by treym »

hi

ezio, send me a pm , alex you've got a email , dongs is the file still under nda ?

as i said to hydra , i mominate myself as maintenainer the doc .

++

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: New MSP command request

Post by ezio »

Alexinparis wrote:Hi,

MSP version can already get from another MSP, no plan to duplicate any info

There is currently a field not used in MSP: BOARD_NAME: 16 char long
A new MSP with just this would be enough ?

I think that this will be perfect.
But the msp version has to be change every time the command is change/added

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Post by ezio »

Or maybe this is better solution
viewtopic.php?p=57855#p57855

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re:

Post by Alexinparis »

ezio wrote:Or maybe this is better solution
viewtopic.php?p=57855#p57855


Hi,

Back on this topic here (to keep clean GPS navigation topic).
Instead of introducing this complexity for all case, I have another suggestion.
MSP_VERSION is not currently used in MSP_IDENT. (always 0 currently)

This field could be renamed to point a specific fork. (MSP_VARIANT or something like that: still 0 for MultiWii main implementation, 1 for baseflight, and so on)
And it would be up to this specific fork to use specific MSP if they want to. (like build date, board revision, …)

About specific MSP:
There is a comment in Protocol.cpp that was added because I don’t want to see anymore “I already use this MSP number for my own implementation, please change”.

//to multiwii developpers/committers : do not add new MSP messages without a proper argumentation/agreement on the forum
//range id [50-99] won't be assigned and can therefore be used for any custom multiwii fork without further MSP id conflict

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: New MSP command request

Post by ezio »

Alexinparis wrote:
ezio wrote:Or maybe this is better solution
viewtopic.php?p=57855#p57855


Hi,

Back on this topic here (to keep clean GPS navigation topic).
Instead of introducing this complexity for all case, I have another suggestion.
MSP_VERSION is not currently used in MSP_IDENT. (always 0 currently)

This field could be renamed to point a specific fork. (MSP_VARIANT or something like that: still 0 for MultiWii main implementation, 1 for baseflight, and so on)
And it would be up to this specific fork to use specific MSP if they want to. (like build date, board revision, …)

About specific MSP:
There is a comment in Protocol.cpp that was added because I don’t want to see anymore “I already use this MSP number for my own implementation, please change”.

//to multiwii developpers/committers : do not add new MSP messages without a proper argumentation/agreement on the forum
//range id [50-99] won't be assigned and can therefore be used for any custom multiwii fork without further MSP id conflict

It will be good enough
Thanks

Post Reply