[BUG] lcd telemetry, checkbox page

[haydent]

the line number is calculated wrong starting at 0 when it should start at 1-4, causing missing line at end
not sure if my fix is best way to do it, but works in my case.
i just took formula from other pages for doing similar thing and it worked...
also i made it show if armed by stick

LCD.cpp
currently:

Code: Select all

    case 3: // checkboxes and modes
    case '3':
    {
      static uint8_t index = 0;
      index %= CHECKBOXITEMS;
      if (index == 0) linenr = 1;
      LCDsetLine((linenr++ + POSSIBLE_OFFSET)%CHECKBOXITEMS);
      LCDprintChar(checkboxitemNames[index]);
      //LCDprintChar((PGM_P)(boxnames[index]));
      LCDprint(' ');
      LCDprint( rcOptions[index] ? 'X' : '.');
      LCDcrlf();
      index++;
      break;
    }

i made it:

Code: Select all

    case 3: // checkboxes and modes
    case '3':
    {
      static uint8_t index = 0;      
      index = linenr++ % CHECKBOXITEMS;
     LCDsetLine((index - POSSIBLE_OFFSET)%CHECKBOXITEMS + 1);
     LCDprintChar(checkboxitemNames[index]);
     //LCDprintChar((PGM_P)(boxnames[index]));
      LCDprint(' ');
      if(index==0 && f.ARMED)LCDprint('X');
      else LCDprint( rcOptions[index] ? 'X' : '.');
      LCDcrlf();
      index++;      
      break;
    }

[Hamburger]

Ok. Nedds more testing. Lcdsetline does indeed require linenr>=1

[haydent]

what needs testing ? is there meant to be a stick command to switch pages and that is what you mean ? can test it or do i need to ?

[Hamburger]

did you verify it worked for double font size (which introduces offset)?

[haydent]

thats the only one i tested

[Hamburger]

done in r1696