[FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

This forum is dedicated to software development related to MultiWii.
It is not the right place to submit a setup problem.
Software download
Post Reply
User avatar
fuh
Posts: 72
Joined: Thu Jun 13, 2013 5:12 pm
Location: Portugal

[FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by fuh »

This patch adds a new feature:
When ONLY_ALLOW_ARM_WITH_GPS_3DFIX is set the FC will only allow arming if the GPS has a 3D fix.

r1685-only_allow_arm_with_gps_3dfix.patch

Note: I did actual live functionality test and everything is working as intended, nevertheless please report back your findings.

o_lampe
Posts: 117
Joined: Sat Nov 02, 2013 5:09 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by o_lampe »

I can't test it ATM, but what happens, when I loose GPS-fix during flight? Will it keep being armed?

User avatar
fuh
Posts: 72
Joined: Thu Jun 13, 2013 5:12 pm
Location: Portugal

[FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by fuh »

Yes it will keep flying.

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by Alexinparis »

Hi,

The patch is applied without option: in this context I think it's a wise idea to not allow arm in any case if a gps is intended to be used.

-ralf-
Posts: 215
Joined: Mon Dec 03, 2012 7:08 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by -ralf- »

Alexinparis wrote:Hi,

The patch is applied without option: in this context I think it's a wise idea to not allow arm in any case if a gps is intended to be used.


Hi Alex,

can you make it optional by GUI? Sometimes I'm flying indoor with no GPS-fix possible. With this
patch its impossible to change indoor/outdoor location without flashing a new sketch.

sismeiro
Posts: 173
Joined: Tue Feb 21, 2012 12:33 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by sismeiro »

-ralf- wrote:can you make it optional by GUI? Sometimes I'm flying indoor with no GPS-fix possible. With this
patch its impossible to change indoor/outdoor location without flashing a new sketch.

I agree that would be nice that we could disable the check of 3dfix before arming also. Sometime we just don't want to use the GPS, only fly around indoor or even outdoor. Thank you.

User avatar
shikra
Posts: 783
Joined: Wed Mar 30, 2011 7:58 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by shikra »

Agree with last two?... Prefer an option to disable

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by Alexinparis »

ok ok, so I re add the #define option.
there are options that are not really one because 99% with use it (the reason I did not include it), but here apparently this is not the case

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by ezio »

Alexinparis wrote:ok ok, so I re add the #define option.
there are options that are not really one because 99% with use it (the reason I did not include it), but here apparently this is not the case

Maybe you can make it on/ off via MSP? It will make more sense that way.

-ralf-
Posts: 215
Joined: Mon Dec 03, 2012 7:08 pm

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by -ralf- »

ezio wrote:
Alexinparis wrote:ok ok, so I re add the #define option.
there are options that are not really one because 99% with use it (the reason I did not include it), but here apparently this is not the case

Maybe you can make it on/ off via MSP? It will make more sense that way.

+1

User avatar
fuh
Posts: 72
Joined: Thu Jun 13, 2013 5:12 pm
Location: Portugal

[FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by fuh »

How about when the option is active if you do try to arm the first time without 3DF it will refuse but if you try to arm it again it will engage ? Like a override.

Having a 3DF when arming is getting more important has the fw evolves into GPS based navigation and RTH failsafe. People may not have good experiences if the do not get good coords on the home location.

But indeed we cannot ask people to reflash the fw every time they switch from indoor to outdoor, nor we can ask them to have a Bluetooth module and an android laying around. There should be a "mechanical" way to override the condition.

McNemisis
Posts: 1
Joined: Thu Aug 14, 2014 1:05 am

Re: [FEATURE] r1685-only_allow_arm_with_gps_3dfix.patch

Post by McNemisis »

New to the forum but been reading it for a while. i like this idea what about a stick combo to arm it in 3d fix mode. should be pretty easy to implement.
option 1 arm like normal
option 2 if gps enabled and you go full pitch (for example) arms in 3d fix mode or refuses :)

Post Reply