Page 1 of 1

Multiwii 2.3 - Trim values

Posted: Fri Jan 24, 2014 2:22 am
by szakacs
Is it possible to extract trim values using debug ??. Client or terminal prog.??
When testing newer versions it would be nice to use them to tune instead of going through the trim process each time.

Re: Multiwii 2.3 - Trim values

Posted: Tue Jan 28, 2014 11:13 pm
by Crashpilot1000
Maybe something like this will do it?

debug[0] = conf.angleTrim[0];
debug[1] = conf.angleTrim[1];

Re: Multiwii 2.3 - Trim values

Posted: Fri Feb 14, 2014 5:42 am
by szakacs
Thanks for that ...
Once I figured out where to place the code, it does what I want.

Re: Multiwii 2.3 - Trim values

Posted: Thu Feb 27, 2014 7:57 am
by ezio
Could we have MSP_ACC_TRIM implemented like in baseflight?

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 1:46 am
by timecop
Would be cool, but it currently conflicts with MSP_BIND (which I'm sure noone actually uses).

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 8:36 am
by Plüschi
timecop wrote:MSP_BIND (which I'm sure noone actually uses).


Because it doesent work .. unless you re-wire your receiver.

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 8:39 am
by timecop
Sounds like MSP_BIND can just go then.

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 3:18 pm
by Alexinparis
ezio wrote:Could we have MSP_ACC_TRIM implemented like in baseflight?


Hi,

MSP_ACC_TRIM sounds nice if you plan to introduce it in your GUI.
I will add it.

MSP_BIND will stay.
I don't know how it works currently with spektrum sat (no problem to patch something if something can be done) , but I consider it's a general purpose button that can be used for other things.

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 3:22 pm
by timecop
OK, what about renaming MSP_BIND to MSP_ACC_TRIM (keeping the ID) and then fixing BIND later.
This way current GUIs that support ACC_TRIM will continue working as if nothing happened.

That MSP_PRIVATE thing could be nice to allocate around this same time, too :)

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 3:59 pm
by Alexinparis
because
- I don't know if if still works, but MSP_BIND used to work (and I suppose it still works as designed) and was here before. Danal introduced it in the past.
- The reference is multiwii_shared. Should I care about the fact baseflight didn't take it into account ?

don't worry I don't forget your request about MSP_PRIVATE, I was just away for some weeks

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 4:04 pm
by timecop
If you wanna get real technical, ACC_TRIM was added to baseflight before multiwii allocated same ID for MSP_BIND.

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 02, 2014 8:17 pm
by ezio
timecop wrote:OK, what about renaming MSP_BIND to MSP_ACC_TRIM (keeping the ID) and then fixing BIND later.
This way current GUIs that support ACC_TRIM will continue working as if nothing happened.


+1

Re: Multiwii 2.3 - Trim values

Posted: Sun Mar 16, 2014 10:39 pm
by ezio
So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

Re: Multiwii 2.3 - Trim values

Posted: Thu Mar 27, 2014 6:19 am
by ezio
ezio wrote:So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

Not important?

Re: Multiwii 2.3 - Trim values

Posted: Thu Mar 27, 2014 11:42 pm
by Alexinparis
timecop wrote:If you wanna get real technical, ACC_TRIM was added to baseflight before multiwii allocated same ID for MSP_BIND.


are you sure ?
acc_trim: baseflight: r231 18 oct 2012
spek_bind: multiwii_shared: r1135 23 sept 2012

Re: Multiwii 2.3 - Trim values

Posted: Thu Mar 27, 2014 11:53 pm
by Alexinparis
ezio wrote:
ezio wrote:So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

Not important?


ok, just modified to please everyone ;)

Re: Multiwii 2.3 - Trim values

Posted: Fri Mar 28, 2014 12:14 am
by ezio
thank you

Re: Multiwii 2.3 - Trim values

Posted: Thu May 01, 2014 2:10 pm
by Benik3
What exactly the MSP_ACC_TRIM and MSP_SET_ACC_TRIM should do?

Thanks :)