Multiwii 2.3 - Trim values

This forum is dedicated to software development related to MultiWii.
It is not the right place to submit a setup problem.
Software download
Post Reply
szakacs
Posts: 18
Joined: Wed Dec 11, 2013 11:53 pm
Location: Sydney, NSW Australia

Multiwii 2.3 - Trim values

Post by szakacs »

Is it possible to extract trim values using debug ??. Client or terminal prog.??
When testing newer versions it would be nice to use them to tune instead of going through the trim process each time.

User avatar
Crashpilot1000
Posts: 631
Joined: Tue Apr 03, 2012 7:38 pm

Re: Multiwii 2.3 - Trim values

Post by Crashpilot1000 »

Maybe something like this will do it?

debug[0] = conf.angleTrim[0];
debug[1] = conf.angleTrim[1];

szakacs
Posts: 18
Joined: Wed Dec 11, 2013 11:53 pm
Location: Sydney, NSW Australia

Re: Multiwii 2.3 - Trim values

Post by szakacs »

Thanks for that ...
Once I figured out where to place the code, it does what I want.

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: Multiwii 2.3 - Trim values

Post by ezio »

Could we have MSP_ACC_TRIM implemented like in baseflight?

timecop
Posts: 1880
Joined: Fri Sep 02, 2011 4:48 pm

Re: Multiwii 2.3 - Trim values

Post by timecop »

Would be cool, but it currently conflicts with MSP_BIND (which I'm sure noone actually uses).

User avatar
Plüschi
Posts: 433
Joined: Thu Feb 21, 2013 6:09 am

Re: Multiwii 2.3 - Trim values

Post by Plüschi »

timecop wrote:MSP_BIND (which I'm sure noone actually uses).


Because it doesent work .. unless you re-wire your receiver.

timecop
Posts: 1880
Joined: Fri Sep 02, 2011 4:48 pm

Re: Multiwii 2.3 - Trim values

Post by timecop »

Sounds like MSP_BIND can just go then.

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: Multiwii 2.3 - Trim values

Post by Alexinparis »

ezio wrote:Could we have MSP_ACC_TRIM implemented like in baseflight?


Hi,

MSP_ACC_TRIM sounds nice if you plan to introduce it in your GUI.
I will add it.

MSP_BIND will stay.
I don't know how it works currently with spektrum sat (no problem to patch something if something can be done) , but I consider it's a general purpose button that can be used for other things.

timecop
Posts: 1880
Joined: Fri Sep 02, 2011 4:48 pm

Re: Multiwii 2.3 - Trim values

Post by timecop »

OK, what about renaming MSP_BIND to MSP_ACC_TRIM (keeping the ID) and then fixing BIND later.
This way current GUIs that support ACC_TRIM will continue working as if nothing happened.

That MSP_PRIVATE thing could be nice to allocate around this same time, too :)

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: Multiwii 2.3 - Trim values

Post by Alexinparis »

because
- I don't know if if still works, but MSP_BIND used to work (and I suppose it still works as designed) and was here before. Danal introduced it in the past.
- The reference is multiwii_shared. Should I care about the fact baseflight didn't take it into account ?

don't worry I don't forget your request about MSP_PRIVATE, I was just away for some weeks

timecop
Posts: 1880
Joined: Fri Sep 02, 2011 4:48 pm

Re: Multiwii 2.3 - Trim values

Post by timecop »

If you wanna get real technical, ACC_TRIM was added to baseflight before multiwii allocated same ID for MSP_BIND.

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: Multiwii 2.3 - Trim values

Post by ezio »

timecop wrote:OK, what about renaming MSP_BIND to MSP_ACC_TRIM (keeping the ID) and then fixing BIND later.
This way current GUIs that support ACC_TRIM will continue working as if nothing happened.


+1

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: Multiwii 2.3 - Trim values

Post by ezio »

So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: Multiwii 2.3 - Trim values

Post by ezio »

ezio wrote:So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

Not important?

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: Multiwii 2.3 - Trim values

Post by Alexinparis »

timecop wrote:If you wanna get real technical, ACC_TRIM was added to baseflight before multiwii allocated same ID for MSP_BIND.


are you sure ?
acc_trim: baseflight: r231 18 oct 2012
spek_bind: multiwii_shared: r1135 23 sept 2012

Alexinparis
Posts: 1630
Joined: Wed Jan 19, 2011 9:07 pm

Re: Multiwii 2.3 - Trim values

Post by Alexinparis »

ezio wrote:
ezio wrote:So yeah
MSP_ACC_TRIM has been added, great !
but how I can implement it in my app when:
in MultiWii:
MSP_ACC_TRIM = 121;
MSP_SET_ACC_TRIM = 215;

in EosBandi Nav:
MSP_SET_NAV_CONFIG = 215; // in message Sets nav config parameters
MSP_NAV_STATUS = 121; // out message Returns navigation status

in Baseflight:
MSP_ACC_TRIM = 240;
MSP_SET_ACC_TRIM = 239;

And where is the logic here?

Not important?


ok, just modified to please everyone ;)

User avatar
ezio
Posts: 827
Joined: Sun Apr 01, 2012 11:03 pm
Location: Paris
Contact:

Re: Multiwii 2.3 - Trim values

Post by ezio »

thank you

User avatar
Benik3
Posts: 25
Joined: Mon Aug 26, 2013 1:06 pm
Contact:

Re: Multiwii 2.3 - Trim values

Post by Benik3 »

What exactly the MSP_ACC_TRIM and MSP_SET_ACC_TRIM should do?

Thanks :)

Post Reply