bug in 2.1 shared r1119 MultiWii.ino on passthru and infligh

This forum is dedicated to software development related to MultiWii.
It is not the right place to submit a setup problem.
Software download
Post Reply
doughboy
Posts: 252
Joined: Tue Sep 04, 2012 7:20 am

bug in 2.1 shared r1119 MultiWii.ino on passthru and infligh

Post by doughboy »

if you enable inflight_acc_calibration, you get a compile error due to passthru not defined.

in line 843, it should have if defined check for fixedwing and helicopter

#if defined(FIXEDWING) || defined(HELICOPTER)
if (rcOptions[BOXPASSTHRU]) { // Use the Passthru Option to activate : Passthru = TRUE Meausrement started, Land and passtrhu = 0 measurement stored
if (!AccInflightCalibrationActive && !AccInflightCalibrationMeasurementDone){
InflightcalibratingA = 50;
}
}else
#endif

thanks

Mis
Posts: 203
Joined: Fri Apr 01, 2011 12:23 am

Re: bug in 2.1 shared r1119 MultiWii.ino on passthru and inf

Post by Mis »

Are you sure ?
From r1119 version - enum box ...

Code: Select all

  #if defined(FIXEDWING) || defined(HELICOPTER) || defined(INFLIGHT_ACC_CALIBRATION)
    BOXPASSTHRU,
  #endif

doughboy
Posts: 252
Joined: Tue Sep 04, 2012 7:20 am

Re: bug in 2.1 shared r1119 MultiWii.ino on passthru and inf

Post by doughboy »

ok, I downloaded my code before r1119 so I should have used the revision I downloaded it from, probably within the last week or so. so that fix must have been done recently.

as for the fix, I was thinking since by design, a define was added to enable passthru only for fixed wing and helicopter, hence I thought the appropriate fix is to add that same condition in in flight calib code. unless adding the condition of fixed wing and heli was a mistake/bug. I thought it actually made sense that passthru only applies to fixed wing and heli though. anyways, I'll update my copy.

doughboy
Posts: 252
Joined: Tue Sep 04, 2012 7:20 am

Re: bug in 2.1 shared r1119 MultiWii.ino on passthru and inf

Post by doughboy »

ok, I see the compile error got fixed in r1110 on sept 12.

Post Reply