Page 1 of 1

[Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Thu Jun 21, 2012 1:20 pm
by Tommie

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 6:26 pm
by Tommie
Am I the only one using CAMTRIG/CAMSTAB?

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 6:37 pm
by kos
camstab/camtrigger have direct visual feedback when tested on the ground .. when i am flying i do not use the gui.

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 6:42 pm
by Tommie
Not e.g. if you are debugging your gimbal system - and it's also an inconsistency, since every other boxitem indicates its activation in the GUI. I cannot find a reason for not applying this simple one line patch.

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 6:48 pm
by kos
Tommie wrote:Not e.g. if you are debugging your gimbal system - and it's also an inconsistency, since every other boxitem indicates its activation in the GUI. I cannot find a reason for not applying this simple one line patch.


what is the benefit ?

having no reason to not do something does not mean it is useful.

i am not against your proposal , i fact i do not care unless the serial protocol is changed before release 2.1


please read this ->

http://manohars.files.wordpress.com/2009/11/97-things-every-software-architect-should-know.pdf

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 7:04 pm
by Tommie
The benefit is seeing whether the switch actually enables the gimbal or camera - so it behaves like any other thing you can switch.

And it's not even changing the protocol, it's just simply plugging a "hole" in the bitmask transmitted; instead of being stuck at 0, the bits will now actually indicate something.

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Posted: Wed Jun 27, 2012 7:09 pm
by kos
..and yes , i did not read you patch, making wrong assumption :)