[Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

This forum is dedicated to software development related to MultiWii.
It is not the right place to submit a setup problem.
Software download
Post Reply

Tommie
Posts: 438
Joined: Sun Apr 08, 2012 9:50 am

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by Tommie »

Am I the only one using CAMTRIG/CAMSTAB?

User avatar
kos
Posts: 286
Joined: Thu Feb 16, 2012 4:51 am
Location: Fr

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by kos »

camstab/camtrigger have direct visual feedback when tested on the ground .. when i am flying i do not use the gui.

Tommie
Posts: 438
Joined: Sun Apr 08, 2012 9:50 am

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by Tommie »

Not e.g. if you are debugging your gimbal system - and it's also an inconsistency, since every other boxitem indicates its activation in the GUI. I cannot find a reason for not applying this simple one line patch.

User avatar
kos
Posts: 286
Joined: Thu Feb 16, 2012 4:51 am
Location: Fr

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by kos »

Tommie wrote:Not e.g. if you are debugging your gimbal system - and it's also an inconsistency, since every other boxitem indicates its activation in the GUI. I cannot find a reason for not applying this simple one line patch.


what is the benefit ?

having no reason to not do something does not mean it is useful.

i am not against your proposal , i fact i do not care unless the serial protocol is changed before release 2.1


please read this ->

http://manohars.files.wordpress.com/2009/11/97-things-every-software-architect-should-know.pdf

Tommie
Posts: 438
Joined: Sun Apr 08, 2012 9:50 am

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by Tommie »

The benefit is seeing whether the switch actually enables the gimbal or camera - so it behaves like any other thing you can switch.

And it's not even changing the protocol, it's just simply plugging a "hole" in the bitmask transmitted; instead of being stuck at 0, the bits will now actually indicate something.

User avatar
kos
Posts: 286
Joined: Thu Feb 16, 2012 4:51 am
Location: Fr

Re: [Patch] Indicate state of CAMSTAB/CAMTRIG in GUI

Post by kos »

..and yes , i did not read you patch, making wrong assumption :)

Post Reply